Skip to content

Make the client_to_server_list and server_to_client_list a dict, since the places we plan to use this DataPart.data, MCP response payload, seem to be built around dicts and don't support lists.#1055

Merged
wrenj merged 3 commits intogoogle:mainfrom
wrenj:list
Apr 6, 2026

Conversation

@wrenj
Copy link
Copy Markdown
Collaborator

@wrenj wrenj commented Apr 2, 2026

Make the client_to_server_list and server_to_client_list a dict, since the places we plan to use this DataPart.data, MCP response payload, seem to be built around dicts and don't support lists.

…e the places we plan to use this DataPart.data, MCP response payload, seem to be built around dicts and don't support lists.
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the JSON schemas for client-to-server and server-to-client message lists in versions 0.9 and 0.10, changing the root structure from a simple array to an object containing an array. The reviewer recommends renaming the "items" property to "messages" to ensure compatibility with existing validation scripts and adding "additionalProperties": false to maintain the strictness of the specification.

@wrenj
Copy link
Copy Markdown
Collaborator Author

wrenj commented Apr 6, 2026

resolved comments, ptal

@wrenj wrenj enabled auto-merge (squash) April 6, 2026 14:46
@wrenj wrenj merged commit db1fbe7 into google:main Apr 6, 2026
13 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in A2UI Apr 6, 2026
@wrenj wrenj mentioned this pull request Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants