Make the client_to_server_list and server_to_client_list a dict, since the places we plan to use this DataPart.data, MCP response payload, seem to be built around dicts and don't support lists.#1055
Merged
wrenj merged 3 commits intogoogle:mainfrom Apr 6, 2026
Conversation
…e the places we plan to use this DataPart.data, MCP response payload, seem to be built around dicts and don't support lists.
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the JSON schemas for client-to-server and server-to-client message lists in versions 0.9 and 0.10, changing the root structure from a simple array to an object containing an array. The reviewer recommends renaming the "items" property to "messages" to ensure compatibility with existing validation scripts and adding "additionalProperties": false to maintain the strictness of the specification.
Collaborator
Author
|
resolved comments, ptal |
sugoi-yuzuru
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the client_to_server_list and server_to_client_list a dict, since the places we plan to use this DataPart.data, MCP response payload, seem to be built around dicts and don't support lists.